]> git.itanic.dy.fi Git - linux-stable/commit
PCI: Restrict ASMedia ASM1062 SATA Max Payload Size Supported
authorMarek Behún <kabel@kernel.org>
Thu, 24 Jun 2021 17:14:18 +0000 (19:14 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Mon, 26 Jul 2021 17:16:35 +0000 (12:16 -0500)
commitb12d93e9958e028856cbcb061b6e64728ca07755
tree8a88003df9db4720320f8c05116734791c6eb1cd
parentb8da302e2955fe4d41eb9d48199242674d77dbe0
PCI: Restrict ASMedia ASM1062 SATA Max Payload Size Supported

The ASMedia ASM1062 SATA controller advertises Max_Payload_Size_Supported
of 512, but in fact it cannot handle incoming TLPs with payload size of
512.

We discovered this issue on PCIe controllers capable of MPS = 512 (Aardvark
and DesignWare), where the issue presents itself as an External Abort.
Bjorn Helgaas says:

  Probably ASM1062 reports a Malformed TLP error when it receives a data
  payload of 512 bytes, and Aardvark, DesignWare, etc convert this to an
  arm64 External Abort. [1]

To avoid this problem, limit the ASM1062 Max Payload Size Supported to 256
bytes, so we set the Max Payload Size of devices that may send TLPs to the
ASM1062 to 256 or less.

[1] https://lore.kernel.org/linux-pci/20210601170907.GA1949035@bjorn-Precision-5520/
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=212695
Link: https://lore.kernel.org/r/20210624171418.27194-2-kabel@kernel.org
Reported-by: Rötti <espressobinboardarmbiantempmailaddress@posteo.de>
Signed-off-by: Marek Behún <kabel@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Krzysztof Wilczyński <kw@linux.com>
Reviewed-by: Pali Rohár <pali@kernel.org>
Cc: stable@vger.kernel.org
drivers/pci/quirks.c