]> git.itanic.dy.fi Git - linux-stable/commit
dm-integrity: don't modify bio's immutable bio_vec in integrity_metadata()
authorMikulas Patocka <mpatocka@redhat.com>
Tue, 5 Dec 2023 15:39:16 +0000 (16:39 +0100)
committerMike Snitzer <snitzer@kernel.org>
Mon, 18 Dec 2023 18:11:05 +0000 (13:11 -0500)
commitb86f4b790c998afdbc88fe1aa55cfe89c4068726
tree1a09a97a61269b74a4d0bb4ec2c86bd072118ffd
parentdb29d79b34d9593179de5f868be45c650923e7b4
dm-integrity: don't modify bio's immutable bio_vec in integrity_metadata()

__bio_for_each_segment assumes that the first struct bio_vec argument
doesn't change - it calls "bio_advance_iter_single((bio), &(iter),
(bvl).bv_len)" to advance the iterator. Unfortunately, the dm-integrity
code changes the bio_vec with "bv.bv_len -= pos". When this code path
is taken, the iterator would be out of sync and dm-integrity would
report errors. This happens if the machine is out of memory and
"kmalloc" fails.

Fix this bug by making a copy of "bv" and changing the copy instead.

Fixes: 7eada909bfd7 ("dm: add integrity target")
Cc: stable@vger.kernel.org # v4.12+
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@kernel.org>
drivers/md/dm-integrity.c