]> git.itanic.dy.fi Git - linux-stable/commit
interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate
authorMike Tipton <mdtipton@codeaurora.org>
Thu, 25 Nov 2021 17:47:51 +0000 (19:47 +0200)
committerGeorgi Djakov <djakov@kernel.org>
Tue, 30 Nov 2021 12:14:19 +0000 (14:14 +0200)
commitb95b668eaaa2574e8ee72f143c52075e9955177e
tree91ce5b7b0f2ac5f979dc0adf0fabaef39a887a6b
parentfa55b7dcdc43c1aa1ba12bca9d2dd4318c2a0dbf
interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate

We're only adding BCMs to the commit list in aggregate(), but there are
cases where pre_aggregate() is called without subsequently calling
aggregate(). In particular, in icc_sync_state() when a node with initial
BW has zero requests. Since BCMs aren't added to the commit list in
these cases, we don't actually send the zero BW request to HW. So the
resources remain on unnecessarily.

Add BCMs to the commit list in pre_aggregate() instead, which is always
called even when there are no requests.

Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
[georgi: remove icc_sync_state for platforms with incomplete support]
Link: https://lore.kernel.org/r/20211125174751.25317-1-djakov@kernel.org
Signed-off-by: Georgi Djakov <djakov@kernel.org>
drivers/interconnect/qcom/icc-rpmh.c
drivers/interconnect/qcom/sm8150.c
drivers/interconnect/qcom/sm8250.c
drivers/interconnect/qcom/sm8350.c