]> git.itanic.dy.fi Git - linux-stable/commit
Bluetooth: initialize skb_queue_head at l2cap_chan_create()
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sun, 21 Mar 2021 22:52:07 +0000 (07:52 +0900)
committerMarcel Holtmann <marcel@holtmann.org>
Mon, 22 Mar 2021 16:04:22 +0000 (17:04 +0100)
commitbe8597239379f0f53c9710dd6ab551bbf535bec6
tree2b4061f449dcf5d99ca7103c84c972cad840c295
parent07528783c7da0b711385f0033a836453b5ec0c9c
Bluetooth: initialize skb_queue_head at l2cap_chan_create()

syzbot is hitting "INFO: trying to register non-static key." message [1],
for "struct l2cap_chan"->tx_q.lock spinlock is not yet initialized when
l2cap_chan_del() is called due to e.g. timeout.

Since "struct l2cap_chan"->lock mutex is initialized at l2cap_chan_create()
immediately after "struct l2cap_chan" is allocated using kzalloc(), let's
as well initialize "struct l2cap_chan"->{tx_q,srej_q}.lock spinlocks there.

[1] https://syzkaller.appspot.com/bug?extid=fadfba6a911f6bf71842

Reported-and-tested-by: syzbot <syzbot+fadfba6a911f6bf71842@syzkaller.appspotmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/l2cap_core.c