]> git.itanic.dy.fi Git - linux-stable/commit
libnvdimm: Fix compilation warnings with W=1
authorQian Cai <cai@lca.pw>
Thu, 16 May 2019 16:04:53 +0000 (12:04 -0400)
committerDan Williams <dan.j.williams@intel.com>
Mon, 20 May 2019 22:02:08 +0000 (15:02 -0700)
commitc01dafad77fea8d64c4fdca0a6031c980842ad65
tree1ee5d95c8c287ffdb4c106b23644c5a88eff365a
parenta188339ca5a396acc588e5851ed7e19f66b0ebd9
libnvdimm: Fix compilation warnings with W=1

Several places (dimm_devs.c, core.c etc) include label.h but only
label.c uses NSINDEX_SIGNATURE, so move its definition to label.c
instead.

In file included from drivers/nvdimm/dimm_devs.c:23:
drivers/nvdimm/label.h:41:19: warning: 'NSINDEX_SIGNATURE' defined but
not used [-Wunused-const-variable=]

Also, some places abuse "/**" which is only reserved for the kernel-doc.

drivers/nvdimm/bus.c:648: warning: cannot understand function prototype:
'struct attribute_group nd_device_attribute_group = '
drivers/nvdimm/bus.c:677: warning: cannot understand function prototype:
'struct attribute_group nd_numa_attribute_group = '

Those are just some member assignments for the "struct attribute_group"
instances and it can't be expressed in the kernel-doc.

Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Signed-off-by: Qian Cai <cai@lca.pw>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/bus.c
drivers/nvdimm/label.c
drivers/nvdimm/label.h