]> git.itanic.dy.fi Git - linux-stable/commit
media: em28xx: initialize refcount before kref_get
authorDongliang Mu <mudongliangabcd@gmail.com>
Sat, 22 Jan 2022 07:44:59 +0000 (15:44 +0800)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Tue, 22 Feb 2022 08:41:11 +0000 (09:41 +0100)
commitc08eadca1bdfa099e20a32f8fa4b52b2f672236d
treef4aae9938eea814aa9b98f8733ae75499a0c30cb
parentdca4f5fdbcd7dddcd2169be2c3bf3057d51b100e
media: em28xx: initialize refcount before kref_get

The commit 47677e51e2a4("[media] em28xx: Only deallocate struct
em28xx after finishing all extensions") adds kref_get to many init
functions (e.g., em28xx_audio_init). However, kref_init is called too
late in em28xx_usb_probe, since em28xx_init_dev before will invoke
those init functions and call kref_get function. Then refcount bug
occurs in my local syzkaller instance.

Fix it by moving kref_init before em28xx_init_dev. This issue occurs
not only in dev but also dev->dev_next.

Fixes: 47677e51e2a4 ("[media] em28xx: Only deallocate struct em28xx after finishing all extensions")
Reported-by: syzkaller <syzkaller@googlegroups.com>
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/media/usb/em28xx/em28xx-cards.c