]> git.itanic.dy.fi Git - linux-stable/commit
net: pcs: xpcs: fix C73 AN not getting enabled
authorVladimir Oltean <vladimir.oltean@nxp.com>
Tue, 16 May 2023 15:44:10 +0000 (18:44 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 May 2023 11:59:53 +0000 (12:59 +0100)
commitc46e78ba9a7a09da4f192dc8df15c4e8a07fb9e0
treedb66f8b7295732da1fa31b67fc50fb9891c7ca8f
parent60829145f1e2650b31ebe6a0ec70a9725b38fa2c
net: pcs: xpcs: fix C73 AN not getting enabled

The XPCS expects clause 73 (copper backplane) autoneg to follow the
ethtool autoneg bit. It actually did that until the blamed
commit inaptly replaced state->an_enabled (coming from ethtool) with
phylink_autoneg_inband() (coming from the device tree or struct
phylink_config), as part of an unrelated phylink_pcs API conversion.

Russell King suggests that state->an_enabled from the original code was
just a proxy for the ethtool Autoneg bit, and that the correct way of
restoring the functionality is to check for this bit in the advertising
mask.

Fixes: 11059740e616 ("net: pcs: xpcs: convert to phylink_pcs_ops")
Link: https://lore.kernel.org/netdev/ZGNt2MFeRolKGFck@shell.armlinux.org.uk/
Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/pcs/pcs-xpcs.c