]> git.itanic.dy.fi Git - linux-stable/commit
blk-lib: fix blkdev_issue_secure_erase
authorMikulas Patocka <mpatocka@redhat.com>
Wed, 14 Sep 2022 20:55:51 +0000 (16:55 -0400)
committerJens Axboe <axboe@kernel.dk>
Thu, 15 Sep 2022 06:25:17 +0000 (00:25 -0600)
commitc4fa368466cc1b60bb92f867741488930ddd6034
treea80c5a294daf07f3ff4951a5ee205721f8cdb48c
parent56f99b8d06ef1ed1c9730948f9f05ac2b930a20b
blk-lib: fix blkdev_issue_secure_erase

There's a bug in blkdev_issue_secure_erase. The statement
"unsigned int len = min_t(sector_t, nr_sects, max_sectors);"
sets the variable "len" to the length in sectors, but the statement
"bio->bi_iter.bi_size = len" treats it as if it were in bytes.
The statements "sector += len << SECTOR_SHIFT" and "nr_sects -= len <<
SECTOR_SHIFT" are thinko.

This patch fixes it.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org # v5.19
Fixes: 44abff2c0b97 ("block: decouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD")
Link: https://lore.kernel.org/r/alpine.LRH.2.02.2209141549480.28100@file01.intranet.prod.int.rdu2.redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-lib.c