]> git.itanic.dy.fi Git - linux-stable/commit
scsi: lpfc: Prevent lpfc_debugfs_lockstat_write() buffer overflow
authorJustin Tee <justin.tee@broadcom.com>
Wed, 1 Mar 2023 23:16:17 +0000 (15:16 -0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 10 Mar 2023 02:21:44 +0000 (21:21 -0500)
commitc6087b82a9146826564a55c5ca0164cac40348f5
treeab6f792cf586afd848903a071cac5e56523913c4
parentfe15c26ee26efa11741a7b632e9f23b01aca4cc6
scsi: lpfc: Prevent lpfc_debugfs_lockstat_write() buffer overflow

A static code analysis tool flagged the possibility of buffer overflow when
using copy_from_user() for a debugfs entry.

Currently, it is possible that copy_from_user() copies more bytes than what
would fit in the mybuf char array.  Add a min() restriction check between
sizeof(mybuf) - 1 and nbytes passed from the userspace buffer to protect
against buffer overflow.

Link: https://lore.kernel.org/r/20230301231626.9621-2-justintee8345@gmail.com
Signed-off-by: Justin Tee <justin.tee@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_debugfs.c