]> git.itanic.dy.fi Git - linux-stable/commit
team: Fix double free in error path
authorArkadi Sharshevsky <arkadis@mellanox.com>
Thu, 8 Mar 2018 10:42:10 +0000 (12:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 8 Mar 2018 16:19:52 +0000 (11:19 -0500)
commitcbcc607e18422555db569b593608aec26111cb0b
treebf0cf929c0f41554e7aecf7810ff3acf8fdaacce
parentcfda06d7362b4151ad9acc4765ad15e8dd969e4a
team: Fix double free in error path

The __send_and_alloc_skb() receives a skb ptr as a parameter but in
case it fails the skb is not valid:
- Send failed and released the skb internally.
- Allocation failed.

The current code tries to release the skb in case of failure which
causes redundant freeing.

Fixes: 9b00cf2d1024 ("team: implement multipart netlink messages for options transfers")
Signed-off-by: Arkadi Sharshevsky <arkadis@mellanox.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team.c