]> git.itanic.dy.fi Git - linux-stable/commit
net/smc: fix fallback failed while sendmsg with fastopen
authorD. Wythe <alibuda@linux.alibaba.com>
Tue, 7 Mar 2023 03:23:46 +0000 (11:23 +0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 8 Mar 2023 13:00:55 +0000 (13:00 +0000)
commitce7ca794712f186da99719e8b4e97bd5ddbb04c3
tree0ebdf30a80064600aa19389e02a32c8f9b05fa97
parent37d9df224d1eec1b434fe9ffa40104c756478c29
net/smc: fix fallback failed while sendmsg with fastopen

Before determining whether the msg has unsupported options, it has been
prematurely terminated by the wrong status check.

For the application, the general usages of MSG_FASTOPEN likes

fd = socket(...)
/* rather than connect */
sendto(fd, data, len, MSG_FASTOPEN)

Hence, We need to check the flag before state check, because the sock
state here is always SMC_INIT when applications tries MSG_FASTOPEN.
Once we found unsupported options, fallback it to TCP.

Fixes: ee9dfbef02d1 ("net/smc: handle sockopts forcing fallback")
Signed-off-by: D. Wythe <alibuda@linux.alibaba.com>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
v2 -> v1: Optimize code style
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/smc/af_smc.c