]> git.itanic.dy.fi Git - linux-stable/commit
af_key: Reject optional tunnel/BEET mode templates in outbound policies
authorTobias Brunner <tobias@strongswan.org>
Tue, 9 May 2023 09:00:06 +0000 (11:00 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Wed, 10 May 2023 05:04:51 +0000 (07:04 +0200)
commitcf3128a7aca55b2eefb68281d44749c683bdc96f
tree63e00f70da6de5f00cf010fbd6b2218d682b0176
parent3d776e31c841ba2f69895d2255a49320bec7cea6
af_key: Reject optional tunnel/BEET mode templates in outbound policies

xfrm_state_find() uses `encap_family` of the current template with
the passed local and remote addresses to find a matching state.
If an optional tunnel or BEET mode template is skipped in a mixed-family
scenario, there could be a mismatch causing an out-of-bounds read as
the addresses were not replaced to match the family of the next template.

While there are theoretical use cases for optional templates in outbound
policies, the only practical one is to skip IPComp states in inbound
policies if uncompressed packets are received that are handled by an
implicitly created IPIP state instead.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Tobias Brunner <tobias@strongswan.org>
Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/key/af_key.c