]> git.itanic.dy.fi Git - linux-stable/commit
soundwire: cadence: fix race condition between suspend and Slave device alerts
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mon, 17 Aug 2020 22:23:40 +0000 (06:23 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 9 Sep 2020 07:44:42 +0000 (13:14 +0530)
commitd2068da5c85697b5880483dd7beaba98e0b62e02
treedf3d8fffa2dabea2d6181b97621a04010ad445c9
parent8564551eec8afdc7aaf68853fbcae559426c9fe7
soundwire: cadence: fix race condition between suspend and Slave device alerts

In system suspend stress cases, the SOF CI reports timeouts. The root
cause is that an alert is generated while the system suspends. The
interrupt handling generates transactions on the bus that will never
be handled because the interrupts are disabled in parallel.

As a result, the transaction never completes and times out on resume.
This error doesn't seem too problematic since it happens in a work
queue, and the system recovers without issues.

Nevertheless, this race condition should not happen. When doing a
system suspend, or when disabling interrupts, we should make sure the
current transaction can complete, and prevent new work from being
queued.

BugLink: https://github.com/thesofproject/linux/issues/2344
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Acked-by: Jaroslav Kysela <perex@perex.cz>
Link: https://lore.kernel.org/r/20200817222340.18042-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/cadence_master.c
drivers/soundwire/cadence_master.h