]> git.itanic.dy.fi Git - linux-stable/commit
netfilter: nf_ct_ftp: fix deadlock when nat rewrite is needed
authorFlorian Westphal <fw@strlen.de>
Tue, 20 Sep 2022 16:31:30 +0000 (18:31 +0200)
committerFlorian Westphal <fw@strlen.de>
Tue, 20 Sep 2022 21:50:03 +0000 (23:50 +0200)
commitd25088932227680988a6b794221e031a7232f137
treebca64dc14c6152bc59d66cf092b67b32c38061e2
parent62ce44c4fff947eebdf10bb582267e686e6835c9
netfilter: nf_ct_ftp: fix deadlock when nat rewrite is needed

We can't use ct->lock, this is already used by the seqadj internals.
When using ftp helper + nat, seqadj will attempt to acquire ct->lock
again.

Revert back to a global lock for now.

Fixes: c783a29c7e59 ("netfilter: nf_ct_ftp: prefer skb_linearize")
Reported-by: Bruno de Paula Larini <bruno.larini@riosoft.com.br>
Signed-off-by: Florian Westphal <fw@strlen.de>
net/netfilter/nf_conntrack_ftp.c