]> git.itanic.dy.fi Git - linux-stable/commit
drm/panfrost: devfreq: set opp to the recommended one to configure regulator
authorClément Péron <peron.clem@gmail.com>
Tue, 6 Sep 2022 15:30:33 +0000 (17:30 +0200)
committerSteven Price <steven.price@arm.com>
Thu, 8 Sep 2022 10:03:52 +0000 (11:03 +0100)
commitd76034a427a2660b080bc155e4fd8f6393eefb48
treecfdecbfa9715d4301d71a5071efafc9a533846e1
parente3d3fd1cea22ada5a06284d7bbb6cd5794d8545a
drm/panfrost: devfreq: set opp to the recommended one to configure regulator

Enabling panfrost GPU OPP with dynamic regulator will make OPP
responsible to enable and configure it.

Unfortunately OPP configure and enable the regulator when an OPP
is asked to be set, which is not the case during
panfrost_devfreq_init().

This leave the regulator unconfigured and if no GPU load is
triggered, no OPP is asked to be set which make the regulator framework
switching it off during regulator_late_cleanup() without
noticing and therefore make the board hang as any access to GPU
memory space make bus locks up.

Call dev_pm_opp_set_opp() with the recommend OPP in
panfrost_devfreq_init() to enable the regulator, this will properly
configure and enable the regulator and will avoid any switch off
by regulator_late_cleanup().

Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Clément Péron <peron.clem@gmail.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220906153034.153321-5-peron.clem@gmail.com
drivers/gpu/drm/panfrost/panfrost_devfreq.c