]> git.itanic.dy.fi Git - linux-stable/commit
nvme: fix reconnection fail due to reserved tag allocation
authorChunguang Xu <chunguang.xu@shopee.com>
Mon, 11 Mar 2024 02:09:27 +0000 (10:09 +0800)
committerKeith Busch <kbusch@kernel.org>
Thu, 14 Mar 2024 18:32:39 +0000 (11:32 -0700)
commitde105068fead55ed5c07ade75e9c8e7f86a00d1d
tree1762f5e1530e9b93e5a724eb3883f20228392a91
parent2bc91743096756d7c97d10c7079617192211369b
nvme: fix reconnection fail due to reserved tag allocation

We found a issue on production environment while using NVMe over RDMA,
admin_q reconnect failed forever while remote target and network is ok.
After dig into it, we found it may caused by a ABBA deadlock due to tag
allocation. In my case, the tag was hold by a keep alive request
waiting inside admin_q, as we quiesced admin_q while reset ctrl, so the
request maked as idle and will not process before reset success. As
fabric_q shares tagset with admin_q, while reconnect remote target, we
need a tag for connect command, but the only one reserved tag was held
by keep alive command which waiting inside admin_q. As a result, we
failed to reconnect admin_q forever. In order to fix this issue, I
think we should keep two reserved tags for admin queue.

Fixes: ed01fee283a0 ("nvme-fabrics: only reserve a single tag")
Signed-off-by: Chunguang Xu <chunguang.xu@shopee.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/core.c
drivers/nvme/host/fabrics.h