]> git.itanic.dy.fi Git - linux-stable/commit
net/ipv6: fix metrics leak
authorSabrina Dubroca <sd@queasysnail.net>
Mon, 30 Jul 2018 14:23:10 +0000 (16:23 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Jul 2018 16:45:57 +0000 (09:45 -0700)
commitdf18b50448fab1dff093731dfd0e25e77e1afcd1
tree0afb2a9351d3d591df033c400255db700d581200
parent822fb18a82abaf4ee7058793d95d340f5dab7bfc
net/ipv6: fix metrics leak

Since commit d4ead6b34b67 ("net/ipv6: move metrics from dst to
rt6_info"), ipv6 metrics are shared and refcounted. rt6_set_from()
assigns the rt->from pointer and increases the refcount on from's
metrics. This reference is never released.

Introduce the fib6_metrics_release() helper and use it to release the
metrics.

Fixes: d4ead6b34b67 ("net/ipv6: move metrics from dst to rt6_info")
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/ip6_fib.c