]> git.itanic.dy.fi Git - linux-stable/commit
arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob
authorBrian Norris <briannorris@chromium.org>
Mon, 22 Aug 2022 23:45:04 +0000 (16:45 -0700)
committerHeiko Stuebner <heiko@sntech.de>
Tue, 23 Aug 2022 12:34:05 +0000 (14:34 +0200)
commite5467359a725de90b6b8d0dd865500f6373828ca
tree6ef6f86aa26ad8598d4063137382891c22bcd04f
parent1ea90b2d293fd8b1f3377c9ed08364ff6f2a8562
arm64: dts: rockchip: Pull up wlan wake# on Gru-Bob

The Gru-Bob board does not have a pull-up resistor on its
WLAN_HOST_WAKE# pin, but Kevin does. The production/vendor kernel
specified the pin configuration correctly as a pull-up, but this didn't
get ported correctly to upstream.

This means Bob's WLAN_HOST_WAKE# pin is floating, causing inconsistent
wakeup behavior.

Note that bt_host_wake_l has a similar dynamic, but apparently the
upstream choice was to redundantly configure both internal and external
pull-up on Kevin (see the "Kevin has an external pull up" comment in
rk3399-gru.dtsi). This doesn't cause any functional problem, although
it's perhaps wasteful.

Fixes: 8559bbeeb849 ("arm64: dts: rockchip: add Google Bob")
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20220822164453.1.I75c57b48b0873766ec993bdfb7bc1e63da5a1637@changeid
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3399-gru-bob.dts
arch/arm64/boot/dts/rockchip/rk3399-gru-chromebook.dtsi