]> git.itanic.dy.fi Git - linux-stable/commit
igc: Fix ambiguity in the ethtool advertising
authorSasha Neftin <sasha.neftin@intel.com>
Thu, 19 Oct 2023 20:36:41 +0000 (13:36 -0700)
committerJakub Kicinski <kuba@kernel.org>
Sat, 21 Oct 2023 01:15:38 +0000 (18:15 -0700)
commite7684d29efdf37304c62bb337ea55b3428ca118e
tree1d6622954526e8dd27b4eebab125be9351f1d30f
parenta9beb7e81bcb876615e1fbb3c07f3f9dba69831f
igc: Fix ambiguity in the ethtool advertising

The 'ethtool_convert_link_mode_to_legacy_u32' method does not allow us to
advertise 2500M speed support and TP (twisted pair) properly. Convert to
'ethtool_link_ksettings_test_link_mode' to advertise supported speed and
eliminate ambiguity.

Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Suggested-by: Dima Ruinskiy <dima.ruinskiy@intel.com>
Suggested-by: Vitaly Lifshits <vitaly.lifshits@intel.com>
Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Naama Meir <naamax.meir@linux.intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://lore.kernel.org/r/20231019203641.3661960-1-jacob.e.keller@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/igc/igc_ethtool.c