]> git.itanic.dy.fi Git - linux-stable/commit
arm64/mm: avoid fixmap race condition when create pud mapping
authorJianyong Wu <jianyong.wu@arm.com>
Tue, 1 Feb 2022 11:44:00 +0000 (19:44 +0800)
committerWill Deacon <will@kernel.org>
Tue, 15 Feb 2022 15:45:24 +0000 (15:45 +0000)
commitee017ee353506fcec58e481673e4331ff198a80e
treedaac32aa1b0b3913c446d0ec3f893b31dcddf4fc
parente921da6bc7cac5f0e8458fe5df18ae08eb538f54
arm64/mm: avoid fixmap race condition when create pud mapping

The 'fixmap' is a global resource and is used recursively by
create pud mapping(), leading to a potential race condition in the
presence of a concurrent call to alloc_init_pud():

kernel_init thread                          virtio-mem workqueue thread
==================                          ===========================

  alloc_init_pud(...)                       alloc_init_pud(...)
  pudp = pud_set_fixmap_offset(...)         pudp = pud_set_fixmap_offset(...)
  READ_ONCE(*pudp)
  pud_clear_fixmap(...)
                                            READ_ONCE(*pudp) // CRASH!

As kernel may sleep during creating pud mapping, introduce a mutex lock to
serialise use of the fixmap entries by alloc_init_pud(). However, there is
no need for locking in early boot stage and it doesn't work well with
KASLR enabled when early boot. So, enable lock when system_state doesn't
equal to "SYSTEM_BOOTING".

Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Fixes: f4710445458c ("arm64: mm: use fixmap when creating page tables")
Link: https://lore.kernel.org/r/20220201114400.56885-1-jianyong.wu@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/mm/mmu.c