]> git.itanic.dy.fi Git - linux-stable/commit
ASoC: tlv320adc3xxx: Don't strip remove function when driver is builtin
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sun, 10 Mar 2024 14:38:51 +0000 (15:38 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 11 Mar 2024 13:31:44 +0000 (13:31 +0000)
commitf31e0d0c2cad23e0cc48731634f85bb2d8707790
tree4f61541f775209fecd0a5d81ecaecd2340d99b1f
parent6c023ad32b192dea51a4f842cc6ecf89bb6238c9
ASoC: tlv320adc3xxx: Don't strip remove function when driver is builtin

Using __exit for the remove function results in the remove callback
being discarded with SND_SOC_TLV320ADC3XXX=y. When such a device gets
unbound (e.g. using sysfs or hotplug), the driver is just removed
without the cleanup being performed. This results in resource leaks. Fix
it by compiling in the remove callback unconditionally.

This also fixes a W=1 modpost warning:

WARNING: modpost: sound/soc/codecs/snd-soc-tlv320adc3xxx: section mismatch in reference: adc3xxx_i2c_driver+0x10 (section: .data) -> adc3xxx_i2c_remove (section: .exit.text)

(which only happens with SND_SOC_TLV320ADC3XXX=m).

Fixes: e9a3b57efd28 ("ASoC: codec: tlv320adc3xxx: New codec driver")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Link: https://msgid.link/r/20240310143852.397212-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/tlv320adc3xxx.c