]> git.itanic.dy.fi Git - linux-stable/commit
power: supply: axp288_fuel_gauge: Fix external_power_changed race
authorHans de Goede <hdegoede@redhat.com>
Sat, 15 Apr 2023 16:07:30 +0000 (18:07 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Mon, 8 May 2023 13:04:53 +0000 (15:04 +0200)
commitf8319774d6f1567d6e7d03653174ab0c82c5c66d
tree2ddeb661d0123795a25c19f09617fb1a45568f37
parenta5299ce4e96f3e8930e9c051b28d8093ada87b08
power: supply: axp288_fuel_gauge: Fix external_power_changed race

fuel_gauge_external_power_changed() dereferences info->bat,
which gets sets in axp288_fuel_gauge_probe() like this:

  info->bat = devm_power_supply_register(dev, &fuel_gauge_desc, &psy_cfg);

As soon as devm_power_supply_register() has called device_add()
the external_power_changed callback can get called. So there is a window
where fuel_gauge_external_power_changed() may get called while
info->bat has not been set yet leading to a NULL pointer dereference.

Fixing this is easy. The external_power_changed callback gets passed
the power_supply which will eventually get stored in info->bat,
so fuel_gauge_external_power_changed() can simply directly use
the passed in psy argument which is always valid.

Fixes: 30abb3d07929 ("power: supply: axp288_fuel_gauge: Take lock before updating the valid flag")
Cc: stable@vger.kernel.org
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/axp288_fuel_gauge.c