]> git.itanic.dy.fi Git - linux-stable/commit
ext4: check iomap type only if ext4_iomap_begin() does not fail
authorBaokun Li <libaokun1@huawei.com>
Fri, 5 May 2023 13:24:29 +0000 (21:24 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Sat, 13 May 2023 22:05:04 +0000 (18:05 -0400)
commitfa83c34e3e56b3c672af38059e066242655271b1
tree987a87260ef4fff2b2d36d5cefa820c9008f2d29
parent4f04351888a83e595571de672e0a4a8b74f4fb31
ext4: check iomap type only if ext4_iomap_begin() does not fail

When ext4_iomap_overwrite_begin() calls ext4_iomap_begin() map blocks may
fail for some reason (e.g. memory allocation failure, bare disk write), and
later because "iomap->type ! = IOMAP_MAPPED" triggers WARN_ON(). When ext4
iomap_begin() returns an error, it is normal that the type of iomap->type
may not match the expectation. Therefore, we only determine if iomap->type
is as expected when ext4_iomap_begin() is executed successfully.

Cc: stable@kernel.org
Reported-by: syzbot+08106c4b7d60702dbc14@syzkaller.appspotmail.com
Link: https://lore.kernel.org/all/00000000000015760b05f9b4eee9@google.com
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20230505132429.714648-1-libaokun1@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/inode.c