From: Timo Kokkonen <kaapeli@itanic.dy.fi>
Date: Wed, 13 Jul 2011 16:43:10 +0000 (+0300)
Subject: quadtree: Remove redundant validity test
X-Git-Url: http://git.itanic.dy.fi/?p=sdl-planets;a=commitdiff_plain;h=5eb47392e0b0b51117b705718f774722a97b99ac

quadtree: Remove redundant validity test

The sole purpose of this test wast to see whether the subtree was
removed correctly. If such condition exists, the failure will be
caught in the quadtree_del function. This test should be removed since
it causes unnecessary runtime overhead also on the non-debug build.

Signed-off-by: Timo Kokkonen <kaapeli@itanic.dy.fi>
---

diff --git a/quadtree.c b/quadtree.c
index 5ea460a..30e306e 100644
--- a/quadtree.c
+++ b/quadtree.c
@@ -622,11 +622,6 @@ static int optimally_move_tree(struct quadtree *tree, struct quadtree *parent,
 	if (quadtree_split_by_node(t, corner, QUADTREE_DOWNRIGHT))
 		moved += optimally_move_tree(tree, parent, corner, ops);
 
-	get_middle_point(corner_orig, &mid);
-	tmp = quadtree_find_nearest(tree, &mid, corner_orig, NULL, 0);
-	if (tmp && tmp != tree)
-		trap();
-
 out:
 	if (debug)
 		printf("Now moved %d nodes, %ld left\n", moved, tree->children);