]> git.itanic.dy.fi Git - linux-stable/commit
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 4 May 2023 23:07:27 +0000 (16:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 May 2023 11:42:11 +0000 (12:42 +0100)
commit06a7b76c5b43050f8c6d10236d290eb5761c8673
tree2d581f08d5559ffaf4b8ad2c2e9f23d227d95d15
parentd2309e0cb27b6871b273fbc1725e93be62570d86
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()

[ Upstream commit 93e0401e0fc0c54b0ac05b687cd135c2ac38187c ]

The call to phy_stop() races with the later call to phy_disconnect(),
resulting in concurrent phy_suspend() calls being run from different
CPUs. The final call to phy_disconnect() ensures that the PHY is
stopped and suspended, too.

Fixes: c96e731c93ff ("net: bcmgenet: connect and disconnect from the PHY state machine")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/genet/bcmgenet.c