]> git.itanic.dy.fi Git - linux-stable/commit
swiotlb: avoid potential left shift overflow
authorChao Gao <chao.gao@intel.com>
Fri, 19 Aug 2022 08:45:37 +0000 (16:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2022 09:32:06 +0000 (11:32 +0200)
commit1a2742552372585e3c865ce6837624f320985ef6
treef93495fc1e54e5a671c55e6c4d666cf4906ff9fe
parent586f8c8330b72b316cb9a83695ef1f1e62ac6fec
swiotlb: avoid potential left shift overflow

[ Upstream commit 3f0461613ebcdc8c4073e235053d06d5aa58750f ]

The second operand passed to slot_addr() is declared as int or unsigned int
in all call sites. The left-shift to get the offset of a slot can overflow
if swiotlb size is larger than 4G.

Convert the macro to an inline function and declare the second argument as
phys_addr_t to avoid the potential overflow.

Fixes: 26a7e094783d ("swiotlb: refactor swiotlb_tbl_map_single")
Signed-off-by: Chao Gao <chao.gao@intel.com>
Reviewed-by: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/dma/swiotlb.c