]> git.itanic.dy.fi Git - linux-stable/commit
usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop
authorWesley Cheng <quic_wcheng@quicinc.com>
Thu, 28 Jul 2022 02:06:47 +0000 (19:06 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:04:00 +0000 (11:04 +0200)
commit4ccf7afa4729bbc3a357552255eea8ba4669692c
treecd3b06a519a1b24f329cea2005008f22701f8a2c
parenta5bdea59f43d71aff925133ab27b06859d452ded
usb: dwc3: gadget: Avoid duplicate requests to enable Run/Stop

[ Upstream commit 040f2dbd2010c43f33ad27249e6dac48456f4d99 ]

Relocate the pullups_connected check until after it is ensured that there
are no runtime PM transitions.  If another context triggered the DWC3
core's runtime resume, it may have already enabled the Run/Stop.  Do not
re-run the entire pullup sequence again, as it may issue a core soft
reset while Run/Stop is already set.

This patch depends on
  commit 69e131d1ac4e ("usb: dwc3: gadget: Prevent repeat pullup()")

Fixes: 77adb8bdf422 ("usb: dwc3: gadget: Allow runtime suspend if UDC unbinded")
Cc: stable <stable@kernel.org>
Signed-off-by: Wesley Cheng <quic_wcheng@quicinc.com>
Link: https://lore.kernel.org/r/20220728020647.9377-1-quic_wcheng@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/dwc3/gadget.c