]> git.itanic.dy.fi Git - linux-stable/commit
interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate
authorMike Tipton <mdtipton@codeaurora.org>
Thu, 25 Nov 2021 17:47:51 +0000 (19:47 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 28 Sep 2022 09:10:28 +0000 (11:10 +0200)
commit4e74179a164dcafc113e602413439ce1c332e7c6
tree0a8976308ecba2bd5abc627c72b789921f78220c
parenta60babeb60ff276963d4756c7fd2e7bf242bb777
interconnect: qcom: icc-rpmh: Add BCMs to commit list in pre_aggregate

commit b95b668eaaa2574e8ee72f143c52075e9955177e upstream.

We're only adding BCMs to the commit list in aggregate(), but there are
cases where pre_aggregate() is called without subsequently calling
aggregate(). In particular, in icc_sync_state() when a node with initial
BW has zero requests. Since BCMs aren't added to the commit list in
these cases, we don't actually send the zero BW request to HW. So the
resources remain on unnecessarily.

Add BCMs to the commit list in pre_aggregate() instead, which is always
called even when there are no requests.

Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
[georgi: remove icc_sync_state for platforms with incomplete support]
Link: https://lore.kernel.org/r/20211125174751.25317-1-djakov@kernel.org
Signed-off-by: Georgi Djakov <djakov@kernel.org>
[dianders: dropped sm8350.c which isn't present in 5.10]
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Alex Elder <elder@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/interconnect/qcom/icc-rpmh.c
drivers/interconnect/qcom/sm8150.c
drivers/interconnect/qcom/sm8250.c