]> git.itanic.dy.fi Git - linux-stable/commit
swiotlb: avoid potential left shift overflow
authorChao Gao <chao.gao@intel.com>
Fri, 19 Aug 2022 08:45:37 +0000 (16:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2022 09:30:07 +0000 (11:30 +0200)
commit4f8d658848087b5efd3c84658fb145474ca0d336
tree6caec8ca5890dde29989bd282e1139794085b226
parentdf82f5ce4f507b62547e8d0a629a38f0a5bc64aa
swiotlb: avoid potential left shift overflow

[ Upstream commit 3f0461613ebcdc8c4073e235053d06d5aa58750f ]

The second operand passed to slot_addr() is declared as int or unsigned int
in all call sites. The left-shift to get the offset of a slot can overflow
if swiotlb size is larger than 4G.

Convert the macro to an inline function and declare the second argument as
phys_addr_t to avoid the potential overflow.

Fixes: 26a7e094783d ("swiotlb: refactor swiotlb_tbl_map_single")
Signed-off-by: Chao Gao <chao.gao@intel.com>
Reviewed-by: Dongli Zhang <dongli.zhang@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/dma/swiotlb.c