]> git.itanic.dy.fi Git - linux-stable/commit
cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()
authorEnzo Matsumiya <ematsumiya@suse.de>
Wed, 17 Aug 2022 19:08:34 +0000 (16:08 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2022 09:32:04 +0000 (11:32 +0200)
commit98127f140bc4db0d19e6e32ed44ed09008a27df0
tree114f6e7776c072673ff7d87408f9390a4ec3df1a
parentdee1e2b18cf5426eed985512ccc6636ec69dbdd6
cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()

[ Upstream commit 400d0ad63b190895e29f43bc75b1260111d3fd34 ]

SMB2_ioctl() is always called with is_fsctl = true, so doesn't make any
sense to have it at all.

Thus, always set SMB2_0_IOCTL_IS_FSCTL flag on the request.

Also, as per MS-SMB2 3.3.5.15 "Receiving an SMB2 IOCTL Request", servers
must fail the request if the request flags is zero anyway.

Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Reviewed-by: Tom Talpey <tom@talpey.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/cifs/smb2file.c
fs/cifs/smb2ops.c
fs/cifs/smb2pdu.c
fs/cifs/smb2proto.h