]> git.itanic.dy.fi Git - linux-stable/commit
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 4 May 2023 23:07:27 +0000 (16:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 May 2023 16:36:51 +0000 (17:36 +0100)
commit99c5acfd1f6a4a4f6ffe41800596f72816660b40
treecf20cba1c913993ffd89615e40ae160c6037056f
parented1283c46d90435a2e84734379e0872f98691ce2
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()

[ Upstream commit 93e0401e0fc0c54b0ac05b687cd135c2ac38187c ]

The call to phy_stop() races with the later call to phy_disconnect(),
resulting in concurrent phy_suspend() calls being run from different
CPUs. The final call to phy_disconnect() ensures that the PHY is
stopped and suspended, too.

Fixes: c96e731c93ff ("net: bcmgenet: connect and disconnect from the PHY state machine")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/genet/bcmgenet.c