]> git.itanic.dy.fi Git - linux-stable/commit
power: supply: bq27xxx: Fix I2C IRQ race on remove
authorHans de Goede <hdegoede@redhat.com>
Sat, 15 Apr 2023 18:23:33 +0000 (20:23 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 May 2023 12:55:32 +0000 (13:55 +0100)
commite01820a94aea99296e500f54b3f36a2985061045
treef229fb3e4b70f00454906fdf612dce2c7cd81282
parentd21b3448577feab33557dcae3d9794d37aa91b01
power: supply: bq27xxx: Fix I2C IRQ race on remove

commit 444ff00734f3878cd54ddd1ed5e2e6dbea9326d5 upstream.

devm_request_threaded_irq() requested IRQs are only free-ed after
the driver's remove function has ran. So the IRQ could trigger and
call bq27xxx_battery_update() after bq27xxx_battery_teardown() has
already run.

Switch to explicitly free-ing the IRQ in bq27xxx_battery_i2c_remove()
to fix this.

Fixes: 8807feb91b76 ("power: bq27xxx_battery: Add interrupt handling support")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/power/supply/bq27xxx_battery_i2c.c