]> git.itanic.dy.fi Git - linux-stable/commitdiff
tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete
authorJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Fri, 8 Feb 2019 16:30:59 +0000 (18:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 27 Apr 2019 07:35:40 +0000 (09:35 +0200)
[ Upstream commit 442601e87a4769a8daba4976ec3afa5222ca211d ]

Return -E2BIG when the transfer is incomplete. The upper layer does
not retry, so not doing that is incorrect behaviour.

Cc: stable@vger.kernel.org
Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
Reviewed-by: Jerry Snitselaar <jsnitsel@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/char/tpm/tpm_i2c_atmel.c

index 32a8e27c5382fe2677393e9f47f5055f1013c163..cc4e642d3180a89977c1fae3634f3968acb5125b 100644 (file)
@@ -69,6 +69,10 @@ static int i2c_atmel_send(struct tpm_chip *chip, u8 *buf, size_t len)
        if (status < 0)
                return status;
 
+       /* The upper layer does not support incomplete sends. */
+       if (status != len)
+               return -E2BIG;
+
        return 0;
 }