]> git.itanic.dy.fi Git - linux-stable/commitdiff
dmaengine: fsl-qdma: Remove a useless devm_kfree()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 7 Jan 2024 10:02:05 +0000 (11:02 +0100)
committerVinod Koul <vkoul@kernel.org>
Mon, 22 Jan 2024 11:29:33 +0000 (16:59 +0530)
'status_head' is a managed resource. It will be freed automatically if
fsl_qdma_prep_status_queue(), and so fsl_qdma_probe(), fails.

Remove the redundant (and harmless) devm_kfree() call.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/6b7f60aa2b92f73b35c586886daffc1a5ac58697.1704621515.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/fsl-qdma.c

index 9b141369bea5dc9337627e1844a43743473381d5..f405c77060ad8b3508e7c75bee09968e1ae9bc78 100644 (file)
@@ -568,10 +568,9 @@ static struct fsl_qdma_queue
                                              status_size,
                                              &status_head->bus_addr,
                                              GFP_KERNEL);
-       if (!status_head->cq) {
-               devm_kfree(&pdev->dev, status_head);
+       if (!status_head->cq)
                return NULL;
-       }
+
        status_head->n_cq = status_size;
        status_head->virt_head = status_head->cq;
        status_head->virt_tail = status_head->cq;