can: bittiming: can_calc_bittiming(): convert from netdev_err() to NL_SET_ERR_MSG_FMT()

Replace the netdev_err() by NL_SET_ERR_MSG_FMT() to better inform the
user about the problem. While there, use %u to print unsigned values
and improve error message a bit.

In case of an error, return -EINVAL instead of -EDOM, this corresponds
better to the actual meaning of the error value.

Link: https://lore.kernel.org/all/20230202110854.2318594-17-mkl@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

diff --git a/drivers/net/can/dev/calc_bittiming.c b/drivers/net/can/dev/calc_bittiming.c
index 4c9e9c0ceff300b7765ad8dee762751b8227de33..3809c148fb88852a8d2c15402913c9bc8d835857 100644 (file)
--- a/drivers/net/can/dev/calc_bittiming.c
+++ b/drivers/net/can/dev/calc_bittiming.c
@@ -134,13 +134,14 @@ int can_calc_bittiming(const struct net_device *dev, struct can_bittiming *bt,
                do_div(v64, bt->bitrate);
                bitrate_error = (u32)v64;
                if (bitrate_error > CAN_CALC_MAX_ERROR) {
-                       netdev_err(dev,
-                                  "bitrate error %d.%d%% too high\n",
-                                  bitrate_error / 10, bitrate_error % 10);
-                       return -EDOM;
+                       NL_SET_ERR_MSG_FMT(extack,
+                                          "bitrate error: %u.%u%% too high",
+                                          bitrate_error / 10, bitrate_error % 10);
+                       return -EINVAL;
                }
-               netdev_warn(dev, "bitrate error %d.%d%%\n",
-                           bitrate_error / 10, bitrate_error % 10);
+               NL_SET_ERR_MSG_FMT(extack,
+                                  "bitrate error: %u.%u%%",
+                                  bitrate_error / 10, bitrate_error % 10);
        }
 
        /* real sample point */