]> git.itanic.dy.fi Git - linux-stable/commitdiff
kfence: use better stack hash seed
authorJason A. Donenfeld <Jason@zx2c4.com>
Mon, 26 Sep 2022 16:32:25 +0000 (18:32 +0200)
committerJason A. Donenfeld <Jason@zx2c4.com>
Thu, 29 Sep 2022 19:37:27 +0000 (21:37 +0200)
As of the prior commit, the RNG will have incorporated both a cycle
counter value and RDRAND, in addition to various other environmental
noise. Therefore, using get_random_u32() will supply a stronger seed
than simply using random_get_entropy(). N.B.: random_get_entropy()
should be considered an internal API of random.c and not generally
consumed.

Cc: Alexander Potapenko <glider@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Marco Elver <elver@google.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
mm/kfence/core.c

index c252081b11dfe57f5d608f385785787c06b72347..239b1b4b094fa8e5edfed9519325cd805cae73a8 100644 (file)
@@ -864,7 +864,7 @@ static void kfence_init_enable(void)
 
 void __init kfence_init(void)
 {
-       stack_hash_seed = (u32)random_get_entropy();
+       stack_hash_seed = get_random_u32();
 
        /* Setting kfence_sample_interval to 0 on boot disables KFENCE. */
        if (!kfence_sample_interval)