]> git.itanic.dy.fi Git - linux-stable/commitdiff
ext4: fix flags validity checking for EXT4_IOC_CHECKPOINT
authorTheodore Ts'o <tytso@mit.edu>
Fri, 2 Jul 2021 17:21:06 +0000 (13:21 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 8 Jul 2021 12:37:31 +0000 (08:37 -0400)
Use the correct bitmask when checking for any not-yet-supported flags.

Link: https://lore.kernel.org/r/20210702173425.1276158-1-tytso@mit.edu
Fixes: 351a0a3fbc35 ("ext4: add ioctl EXT4_IOC_CHECKPOINT")
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Leah Rumancik <leah.rumancik@gmail.com>
fs/ext4/ioctl.c

index 5730aeca563c83b4b3ad235db5cb0968a21fd5df..6eed6170aded6739dee6f72fb2fdf0b5d1bb5395 100644 (file)
@@ -823,7 +823,7 @@ static int ext4_ioctl_checkpoint(struct file *filp, unsigned long arg)
        if (!EXT4_SB(sb)->s_journal)
                return -ENODEV;
 
-       if (flags & ~JBD2_JOURNAL_FLUSH_VALID)
+       if (flags & ~EXT4_IOC_CHECKPOINT_FLAG_VALID)
                return -EINVAL;
 
        q = bdev_get_queue(EXT4_SB(sb)->s_journal->j_dev);