]> git.itanic.dy.fi Git - linux-stable/commitdiff
net: hns3: limit the error logging in the hns3_clean_tx_ring()
authorYunsheng Lin <linyunsheng@huawei.com>
Tue, 21 Jan 2020 08:42:05 +0000 (16:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 21 Jan 2020 10:46:20 +0000 (11:46 +0100)
The error log printed by netdev_err() in the hns3_clean_tx_ring()
may spam the kernel log.

This patch uses hns3_rl_err() to ratelimit the error log in the
hns3_clean_tx_ring().

Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c

index 914a7630ac48aac787286d382f1e90f6138de8c9..f5790282bd1900f04f45261deda449ac02d5f657 100644 (file)
@@ -2540,8 +2540,8 @@ void hns3_clean_tx_ring(struct hns3_enet_ring *ring)
        rmb(); /* Make sure head is ready before touch any data */
 
        if (unlikely(!is_valid_clean_head(ring, head))) {
-               netdev_err(netdev, "wrong head (%d, %d-%d)\n", head,
-                          ring->next_to_use, ring->next_to_clean);
+               hns3_rl_err(netdev, "wrong head (%d, %d-%d)\n", head,
+                           ring->next_to_use, ring->next_to_clean);
 
                u64_stats_update_begin(&ring->syncp);
                ring->stats.io_err_cnt++;