]> git.itanic.dy.fi Git - linux-stable/commitdiff
soc/tegra: fuse: Add missing of_node_put()
authorLiang He <windhl@126.com>
Wed, 15 Jun 2022 12:32:32 +0000 (20:32 +0800)
committerThierry Reding <treding@nvidia.com>
Thu, 15 Sep 2022 10:38:43 +0000 (12:38 +0200)
In tegra_init_apbmisc(), of_find_matching_node() will return a node
pointer with refcount incremented. We should use of_node_put() in each
failure path or when it is not used anymore.

Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/soc/tegra/fuse/tegra-apbmisc.c

index 590c862538d0aa3d342eb780c346f0af3b88785c..eea5de3e5fa55a5a1864f478fd4b9bb1537cda4f 100644 (file)
@@ -182,12 +182,12 @@ void __init tegra_init_apbmisc(void)
                 */
                if (of_address_to_resource(np, 0, &apbmisc) < 0) {
                        pr_err("failed to get APBMISC registers\n");
-                       return;
+                       goto put;
                }
 
                if (of_address_to_resource(np, 1, &straps) < 0) {
                        pr_err("failed to get strapping options registers\n");
-                       return;
+                       goto put;
                }
        }
 
@@ -208,4 +208,7 @@ void __init tegra_init_apbmisc(void)
        }
 
        long_ram_code = of_property_read_bool(np, "nvidia,long-ram-code");
+
+put:
+       of_node_put(np);
 }