]> git.itanic.dy.fi Git - linux-stable/commitdiff
powerpc/pci_dn: Add missing of_node_put()
authorLiang He <windhl@126.com>
Fri, 1 Jul 2022 13:17:50 +0000 (21:17 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 5 Sep 2022 07:30:25 +0000 (17:30 +1000)
In pci_add_device_node_info(), use of_node_put() to drop the reference
to 'parent' returned by of_get_parent() to keep refcount balance.

Fixes: cca87d303c85 ("powerpc/pci: Refactor pci_dn")
Co-authored-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Reviewed-by: Tyrel Datwyler <tyreld@linux.ibm.com>
Link: https://lore.kernel.org/r/20220701131750.240170-1-windhl@126.com
arch/powerpc/kernel/pci_dn.c

index 7a35fc25a304653d637d92c8030b31789a8bb5e7..38561d6a2079216b7472e78f6f05d6d9151bab03 100644 (file)
@@ -330,6 +330,7 @@ struct pci_dn *pci_add_device_node_info(struct pci_controller *hose,
        INIT_LIST_HEAD(&pdn->list);
        parent = of_get_parent(dn);
        pdn->parent = parent ? PCI_DN(parent) : NULL;
+       of_node_put(parent);
        if (pdn->parent)
                list_add_tail(&pdn->list, &pdn->parent->child_list);