]> git.itanic.dy.fi Git - linux-stable/commitdiff
slimbus: core: Remove usage of the deprecated ida_simple_xx() API
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 24 Feb 2024 11:41:37 +0000 (11:41 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Apr 2024 13:32:16 +0000 (15:32 +0200)
[ Upstream commit 89ffa4cccec54467446f141a79b9e36893079fb8 ]

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

Note that the upper limit of ida_simple_get() is exclusive, but the one of
ida_alloc_range() is inclusive. So change this change allows one more
device. Previously address 0xFE was never used.

Fixes: 46a2bb5a7f7e ("slimbus: core: Add slim controllers support")
Cc: Stable@vger.kernel.org
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20240224114137.85781-2-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/slimbus/core.c

index d43873bb5fe6df58d212122abf3fa1d92121914f..01cbd462198107b2eb1de205bb7aa1d933420c93 100644 (file)
@@ -436,8 +436,8 @@ static int slim_device_alloc_laddr(struct slim_device *sbdev,
                if (ret < 0)
                        goto err;
        } else if (report_present) {
-               ret = ida_simple_get(&ctrl->laddr_ida,
-                                    0, SLIM_LA_MANAGER - 1, GFP_KERNEL);
+               ret = ida_alloc_max(&ctrl->laddr_ida,
+                                   SLIM_LA_MANAGER - 1, GFP_KERNEL);
                if (ret < 0)
                        goto err;