]> git.itanic.dy.fi Git - linux-stable/commitdiff
xfs: move the xfs_attr_sf_lookup tracepoint
authorChristoph Hellwig <hch@lst.de>
Wed, 20 Dec 2023 06:34:57 +0000 (07:34 +0100)
committerChandan Babu R <chandanbabu@kernel.org>
Fri, 29 Dec 2023 08:07:04 +0000 (13:37 +0530)
trace_xfs_attr_sf_lookup is currently only called by
xfs_attr_shortform_lookup, which despit it's name is a simple helper for
xfs_attr_shortform_addname, which has it's own tracing.  Move the
callsite to xfs_attr_shortform_getvalue, which is the closest thing to
a high level lookup we have for the Linux xattr API.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
fs/xfs/libxfs/xfs_attr_leaf.c

index 2e3334ac32287a091277c3a8022c0aec7d1f0e74..37474af8ee46337722674f86244b1ab9869959f9 100644 (file)
@@ -876,8 +876,6 @@ xfs_attr_shortform_lookup(
        struct xfs_attr_sf_entry        *sfe;
        int                             i;
 
-       trace_xfs_attr_sf_lookup(args);
-
        ASSERT(ifp->if_format == XFS_DINODE_FMT_LOCAL);
        sfe = &sf->list[0];
        for (i = 0; i < sf->hdr.count;
@@ -905,6 +903,9 @@ xfs_attr_shortform_getvalue(
        int                             i;
 
        ASSERT(args->dp->i_af.if_format == XFS_DINODE_FMT_LOCAL);
+
+       trace_xfs_attr_sf_lookup(args);
+
        sfe = &sf->list[0];
        for (i = 0; i < sf->hdr.count;
                                sfe = xfs_attr_sf_nextentry(sfe), i++) {