]> git.itanic.dy.fi Git - linux-stable/commitdiff
wifi: cfg80211: debugfs: fix return type in ht40allow_map_read()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Aug 2022 07:03:21 +0000 (10:03 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 15 Sep 2022 10:17:02 +0000 (12:17 +0200)
[ Upstream commit d776763f48084926b5d9e25507a3ddb7c9243d5e ]

The return type is supposed to be ssize_t, which is signed long,
but "r" was declared as unsigned int.  This means that on 64 bit systems
we return positive values instead of negative error codes.

Fixes: 80a3511d70e8 ("cfg80211: add debugfs HT40 allow map")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/YutvOQeJm0UjLhwU@kili
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/wireless/debugfs.c

index 30fc6eb352bccdf70a9e8433af0aae82bf5157cd..e6410487e25da0440967082204f10b36f9bf9d3b 100644 (file)
@@ -68,9 +68,10 @@ static ssize_t ht40allow_map_read(struct file *file,
 {
        struct wiphy *wiphy = file->private_data;
        char *buf;
-       unsigned int offset = 0, buf_size = PAGE_SIZE, i, r;
+       unsigned int offset = 0, buf_size = PAGE_SIZE, i;
        enum nl80211_band band;
        struct ieee80211_supported_band *sband;
+       ssize_t r;
 
        buf = kzalloc(buf_size, GFP_KERNEL);
        if (!buf)