mei: bus-fixup:upon error print return values of send and receive

[ Upstream commit 4b8659e2c258e4fdac9ccdf06cc20c0677894ef9 ]

For easier debugging, upon error, print also return values
from __mei_cl_recv() and __mei_cl_send() functions.

Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
Link: https://lore.kernel.org/r/20221212214933.275434-1-tomas.winkler@intel.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/misc/mei/bus-fixup.c b/drivers/misc/mei/bus-fixup.c
index 4e30fa98fe7d31ec79957f66e17123f290179d05..c4c1275581ec93f0918df49f6afbafcd4a5de16e 100644 (file)
--- a/drivers/misc/mei/bus-fixup.c
+++ b/drivers/misc/mei/bus-fixup.c
@@ -172,7 +172,7 @@ static int mei_fwver(struct mei_cl_device *cldev)
        ret = __mei_cl_send(cldev->cl, (u8 *)&req, sizeof(req),
                            MEI_CL_IO_TX_BLOCKING);
        if (ret < 0) {
-               dev_err(&cldev->dev, "Could not send ReqFWVersion cmd\n");
+               dev_err(&cldev->dev, "Could not send ReqFWVersion cmd ret = %d\n", ret);
                return ret;
        }
 
@@ -184,7 +184,7 @@ static int mei_fwver(struct mei_cl_device *cldev)
                 * Should be at least one version block,
                 * error out if nothing found
                 */
-               dev_err(&cldev->dev, "Could not read FW version\n");
+               dev_err(&cldev->dev, "Could not read FW version ret = %d\n", bytes_recv);
                return -EIO;
        }
 
@@ -332,7 +332,7 @@ static int mei_nfc_if_version(struct mei_cl *cl,
 
        ret = __mei_cl_send(cl, (u8 *)&cmd, sizeof(cmd), MEI_CL_IO_TX_BLOCKING);
        if (ret < 0) {
-               dev_err(bus->dev, "Could not send IF version cmd\n");
+               dev_err(bus->dev, "Could not send IF version cmd ret = %d\n", ret);
                return ret;
        }
 
@@ -346,7 +346,7 @@ static int mei_nfc_if_version(struct mei_cl *cl,
        ret = 0;
        bytes_recv = __mei_cl_recv(cl, (u8 *)reply, if_version_length, 0, 0);
        if (bytes_recv < 0 || (size_t)bytes_recv < if_version_length) {
-               dev_err(bus->dev, "Could not read IF version\n");
+               dev_err(bus->dev, "Could not read IF version ret = %d\n", bytes_recv);
                ret = -EIO;
                goto err;
        }