]> git.itanic.dy.fi Git - linux-stable/commitdiff
can: at91_can: at91_irq_tx(): remove one level of indention
authorMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 23 Apr 2023 11:47:40 +0000 (13:47 +0200)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Thu, 5 Oct 2023 19:45:18 +0000 (21:45 +0200)
Improve code readability by removing one level of indention.

If a mailbox is not ready, continue the loop early.

Link: https://lore.kernel.org/all/20231005-at91_can-rx_offload-v2-3-9987d53600e0@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/at91_can.c

index 367ccf109652f848a40979e86e553b6d09a556b2..966980d4b5ddd79f8c1cf0b82aadac256a7b97d0 100644 (file)
@@ -844,15 +844,14 @@ static void at91_irq_tx(struct net_device *dev, u32 reg_sr)
                 * parked in the echo queue.
                 */
                reg_msr = at91_read(priv, AT91_MSR(mb));
-               if (likely(reg_msr & AT91_MSR_MRDY &&
-                          ~reg_msr & AT91_MSR_MABT)) {
-                       /* _NOTE_: subtract AT91_MB_TX_FIRST offset from mb! */
-                       dev->stats.tx_bytes +=
-                               can_get_echo_skb(dev,
-                                                mb - get_mb_tx_first(priv),
-                                                NULL);
-                       dev->stats.tx_packets++;
-               }
+               if (unlikely(!(reg_msr & AT91_MSR_MRDY &&
+                              ~reg_msr & AT91_MSR_MABT)))
+                       continue;
+
+               /* _NOTE_: subtract AT91_MB_TX_FIRST offset from mb! */
+               dev->stats.tx_bytes +=
+                       can_get_echo_skb(dev, mb - get_mb_tx_first(priv), NULL);
+               dev->stats.tx_packets++;
        }
 
        /* restart queue if we don't have a wrap around but restart if