]> git.itanic.dy.fi Git - linux-stable/commitdiff
mmc: cavium-octeon: Add of_node_put() when breaking out of loop
authorLiang He <windhl@126.com>
Tue, 19 Jul 2022 09:52:15 +0000 (17:52 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 21 Jul 2022 16:02:55 +0000 (18:02 +0200)
In octeon_mmc_probe(), we should call of_node_put() when breaking
out of for_each_child_of_node() which has increased and decreased
the refcount during each iteration.

Fixes: 01d95843335c ("mmc: cavium: Add MMC support for Octeon SOCs.")
Signed-off-by: Liang He <windhl@126.com>
Acked-by: Robert Richter <rric@kernel.org>
Link: https://lore.kernel.org/r/20220719095216.1241601-1-windhl@126.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/cavium-octeon.c

index 2c4b2df52adb1f774d77296dc9bbc168864f4f05..12dca91a8ef61594b7cba1c715b92b4bfa2bcffe 100644 (file)
@@ -277,6 +277,7 @@ static int octeon_mmc_probe(struct platform_device *pdev)
                if (ret) {
                        dev_err(&pdev->dev, "Error populating slots\n");
                        octeon_mmc_set_shared_power(host, 0);
+                       of_node_put(cn);
                        goto error;
                }
                i++;