]> git.itanic.dy.fi Git - linux-stable/commitdiff
drm/bridge: anx7625: Fix refcount bug in anx7625_parse_dt()
authorLiang He <windhl@126.com>
Tue, 19 Jul 2022 06:54:46 +0000 (14:54 +0800)
committerRobert Foss <robert.foss@linaro.org>
Tue, 19 Jul 2022 12:48:31 +0000 (14:48 +0200)
In anx7625_parse_dt(), 'pdata->mipi_host_node' will be assigned a
new reference with of_graph_get_remote_node() which will increase
the refcount of the object, correspondingly, we should call
of_node_put() for the old reference stored in the 'pdata->mipi_host_node'.

Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP")
Signed-off-by: Liang He <windhl@126.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220719065447.1080817-1-windhl@126.com
drivers/gpu/drm/bridge/analogix/anx7625.c

index d1f1d525aeb6d4e4bb788a61914d9682fc318dbb..79fc7a50b4976dde5c46fb1fd3c65d882a010c04 100644 (file)
@@ -1642,6 +1642,7 @@ static int anx7625_parse_dt(struct device *dev,
        anx7625_get_swing_setting(dev, pdata);
 
        pdata->is_dpi = 0; /* default dsi mode */
+       of_node_put(pdata->mipi_host_node);
        pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0);
        if (!pdata->mipi_host_node) {
                DRM_DEV_ERROR(dev, "fail to get internal panel.\n");