]> git.itanic.dy.fi Git - linux-stable/commitdiff
hwmon: (vt8231) Do PCI error checks on own line
authorIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Thu, 24 Aug 2023 13:28:24 +0000 (16:28 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 25 Aug 2023 13:19:29 +0000 (06:19 -0700)
Instead of if conditions with line splits, use the usual error handling
pattern with a separate variable to improve readability.

No functional changes intended.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20230824132832.78705-7-ilpo.jarvinen@linux.intel.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/vt8231.c

index b7c6392ba67374ce2e00b28129ebf18579e03363..16bc16d33cd1d5ce9055ad30810884632b67694e 100644 (file)
@@ -971,13 +971,15 @@ static int vt8231_pci_probe(struct pci_dev *dev,
                                const struct pci_device_id *id)
 {
        u16 address, val;
+       int ret;
+
        if (force_addr) {
                address = force_addr & 0xff00;
                dev_warn(&dev->dev, "Forcing ISA address 0x%x\n",
                         address);
 
-               if (PCIBIOS_SUCCESSFUL !=
-                   pci_write_config_word(dev, VT8231_BASE_REG, address | 1))
+               ret = pci_write_config_word(dev, VT8231_BASE_REG, address | 1);
+               if (ret != PCIBIOS_SUCCESSFUL)
                        return -ENODEV;
        }
 
@@ -997,9 +999,8 @@ static int vt8231_pci_probe(struct pci_dev *dev,
 
        if (!(val & 0x0001)) {
                dev_warn(&dev->dev, "enabling sensors\n");
-               if (PCIBIOS_SUCCESSFUL !=
-                       pci_write_config_word(dev, VT8231_ENABLE_REG,
-                                                       val | 0x0001))
+               ret = pci_write_config_word(dev, VT8231_ENABLE_REG, val | 0x1);
+               if (ret != PCIBIOS_SUCCESSFUL)
                        return -ENODEV;
        }