]> git.itanic.dy.fi Git - linux-stable/commitdiff
drm/i915: Drop has_gt_uc from device info
authorJosé Roberto de Souza <jose.souza@intel.com>
Thu, 5 May 2022 19:35:18 +0000 (12:35 -0700)
committerJosé Roberto de Souza <jose.souza@intel.com>
Fri, 6 May 2022 16:28:12 +0000 (09:28 -0700)
No need to have this parameter in intel_device_info struct
as all platforms with graphics version 9 or newer has graphics
microcontroller.

As a side effect of the of removal this flag, it will not be printed
in dmesg during driver load anymore and developers will have to rely
on to check the macro and compare with platform being used and IP
versions of it.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220505193524.276400-1-jose.souza@intel.com
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/i915_gpu_error.c
drivers/gpu/drm/i915/i915_pci.c
drivers/gpu/drm/i915/intel_device_info.h

index 3ed9021c615d2e60228c1810e03ca8e1e17fff56..d71ed8d272c5594073191027760cb165975503d8 100644 (file)
@@ -1350,7 +1350,7 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,
  */
 #define HAS_FLAT_CCS(dev_priv)   (INTEL_INFO(dev_priv)->has_flat_ccs)
 
-#define HAS_GT_UC(dev_priv)    (INTEL_INFO(dev_priv)->has_gt_uc)
+#define HAS_GT_UC(dev_priv)    (GRAPHICS_VER(dev_priv) >= 9)
 
 #define HAS_POOLED_EU(dev_priv)        (INTEL_INFO(dev_priv)->has_pooled_eu)
 
index 0512c66fa4f3f1fd48dcd4e60c454deb51fa6ea2..5bd9cb89985276a2903bbe877fcaa46975c1fe22 100644 (file)
@@ -2008,7 +2008,7 @@ __i915_gpu_coredump(struct intel_gt *gt, intel_engine_mask_t engine_mask, u32 du
                        return ERR_PTR(-ENOMEM);
                }
 
-               if (INTEL_INFO(i915)->has_gt_uc) {
+               if (HAS_GT_UC(i915)) {
                        error->gt->uc = gt_record_uc(error->gt, compress);
                        if (error->gt->uc) {
                                if (dump_flags & CORE_DUMP_FLAG_IS_GUC_CAPTURE)
index 987bdeb090a51c574eb3d05581eaa3252954c858..a5f09a2f7472fec10d83d8c179d7445963fe4a46 100644 (file)
@@ -644,7 +644,6 @@ static const struct intel_device_info chv_info = {
        GEN(9), \
        GEN9_DEFAULT_PAGE_SIZES, \
        .display.has_dmc = 1, \
-       .has_gt_uc = 1, \
        .display.has_hdcp = 1, \
        .display.has_ipc = 1, \
        .display.has_psr = 1, \
@@ -705,7 +704,6 @@ static const struct intel_device_info skl_gt4_info = {
        .has_rps = true, \
        .display.has_dp_mst = 1, \
        .has_logical_ring_contexts = 1, \
-       .has_gt_uc = 1, \
        .dma_mask_size = 39, \
        .ppgtt_type = INTEL_PPGTT_FULL, \
        .ppgtt_size = 48, \
@@ -1008,7 +1006,6 @@ static const struct intel_device_info adl_p_info = {
        .has_64bit_reloc = 1, \
        .has_flat_ccs = 1, \
        .has_global_mocs = 1, \
-       .has_gt_uc = 1, \
        .has_llc = 1, \
        .has_logical_ring_contexts = 1, \
        .has_logical_ring_elsq = 1, \
index ec0b8095e7fa3c7d9c8900b5df32e22879477c56..93396c49488c0d1491257ddf912b02abb9b240fd 100644 (file)
@@ -141,7 +141,6 @@ enum intel_ppgtt_type {
        func(has_4tile); \
        func(has_flat_ccs); \
        func(has_global_mocs); \
-       func(has_gt_uc); \
        func(has_heci_pxp); \
        func(has_heci_gscfi); \
        func(has_guc_deprivilege); \