]> git.itanic.dy.fi Git - linux-stable/commitdiff
libsas: fix NCQ mixing with non-NCQ
authorDavid Milburn <dmilburn@redhat.com>
Fri, 3 Sep 2010 22:13:03 +0000 (17:13 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 22 Nov 2010 18:43:10 +0000 (10:43 -0800)
commit f0ad30d3d2dc924decc0e10b1ff6dc32525a5d99 upstream.

Some cards (like mvsas) have issue troubles if non-NCQ commands are
mixed with NCQ ones.  Fix this by using the libata default NCQ check
routine which waits until all NCQ commands are complete before issuing
a non-NCQ one.  The impact to cards (like aic94xx) which don't need
this logic should be minimal

Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/libsas/sas_ata.c

index 48ee8c7f5bdd270351bcdf0dae895e0ae572a3f2..d2eec44c91288eb21cf852333fffea163145b7da 100644 (file)
@@ -346,6 +346,7 @@ static int sas_ata_scr_read(struct ata_port *ap, unsigned int sc_reg_in,
 static struct ata_port_operations sas_sata_ops = {
        .phy_reset              = sas_ata_phy_reset,
        .post_internal_cmd      = sas_ata_post_internal,
+       .qc_defer               = ata_std_qc_defer,
        .qc_prep                = ata_noop_qc_prep,
        .qc_issue               = sas_ata_qc_issue,
        .qc_fill_rtf            = sas_ata_qc_fill_rtf,